Snapshot dev host cleanup environment - #678
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 957df36 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
commit: |
ScriptedAlchemy
force-pushed
the
fix/dev-host-cleanup-env
branch
from
September 6, 2026 09:56
fdae0a2 to
957df36
Compare
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
process.envbefore server close from redirecting cleanup or making host binaries disappearFollow-up for #677 after the merged main integration matrix exposed the teardown boundary.
Validation
pnpm build— passedpnpm typecheck— passedpnpm lint— passedpnpm test:unit— passedpnpm exec rstest packages/workbench/tests/sessions.e2e.test.ts— passed on the branch rebased onto Fix development host install lifecycle #677; this is the exact test that failed on all three main integration matrix versionsDeslop
Deslop: GPT-5.6 Sol, 0 edits.
Self-review
Reviewer: Claude Fable 5.1 Thinking High
First pass findings and disposition:
origin/main, so the test did not include Fix development host install lifecycle #677. Fixed by fetching and rebasing onto merge commitc2e69f20cc.InstallCommandRunnertoexecFile.homedir()could still change. Fixed by resolving and retaining home at manager construction.Second pass: both blockers resolved; no blocking findings. The exact merged-main E2E is the regression guard.